dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: linus: apps/codecs mpa.c,1.21,1.22

Re: linus: apps/codecs mpa.c,1.21,1.22

From: Magnus Holmgren <>
Date: Tue, 23 Aug 2005 17:02:59 +0200 wrote:

> Modified Files:
> mpa.c
> Log Message:
> iriver: The MP3 codec didn't take the ID3 tag size into account when seeking

Huh? What about the following playback.c:mp3_get_file_pos?

     else if (pos < (int)id3->first_frame_offset)
         /* skip past id3v2 tag and other leading garbage */
         pos = id3->first_frame_offset;

But it does mean something in mpa.c should be changed though. The following:

     if (newpos == 0)
         frame_skip = start_skip;

should probably read:

     if (newpos <= ci->id3->first_frame_offset)
         frame_skip = start_skip;

Received on 2005-08-23

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy