Rockbox mail archiveSubject: Bookmarking playlists on the iRiver
Bookmarking playlists on the iRiver
Date: Thu, 15 Sep 2005 09:19:27 +0200 (MEST)
I've noticed that bookmarking tends to stop working when using long playlists on
the iRiver. I wonder if that might be caused by the playback code "deleting"
playlist entries. The bookmarking code does a "system check" before creating
a bookmark, where among other things it checks if the playlist is modified,
and deleting a playlist entry makes the playlist modified. Yet another reason
why deleting playlist entries from the playback code could be considered
However, where the bookmarking code checks for a modified playlist, one can
read the comment "can't bookmark while in the queue", suggesting that the
check is in fact not quite correct. Perhaps it should just check if the
current track is queued? That seems like the proper thing to do.
A few other things regarding bookmarking:
* What about a splash when bookmarking isn't possible (especially for a
queued track)? As it is now, Rockbox silently ignores any bookmarking requests...
* With autobookmarking and fade on stop on at the same time, it takes quite a
while before the bookmark is actually written. What about making auto-bookmarking
a two step thing? Before starting a fade, call a function that if bookmark
is set to auto, spins up the disk so that when the fade is complete, a bookmark
can be written more quickly. And perhaps that first function should also
ask the bookmarking question, if so configured?
Received on 2005-09-15