Rockbox mail archiveSubject: Re: Bookmarking playlists on the iRiver
Re: Bookmarking playlists on the iRiver
From: Hardeep Sidhu <hardeeps_at_pobox.com>
Date: Thu, 15 Sep 2005 12:51:28 -0700
> I've noticed that bookmarking tends to stop working when using long playlists on
> the iRiver. I wonder if that might be caused by the playback code "deleting"
> playlist entries. The bookmarking code does a "system check" before creating
> a bookmark, where among other things it checks if the playlist is modified,
> and deleting a playlist entry makes the playlist modified. Yet another reason
> why deleting playlist entries from the playback code could be considered
> bad. :)
> However, where the bookmarking code checks for a modified playlist, one can
> read the comment "can't bookmark while in the queue", suggesting that the
> check is in fact not quite correct. Perhaps it should just check if the
> current track is queued? That seems like the proper thing to do.
It's the other way around, the check is correct but the comment isn't.
Most of the playlist modifications (insert, delete, etc.) are stored in
the playlist control file which isn't saved with the bookmark. Without
this information, the bookmark may resume on the wrong track because the
index is incorrect.
Received on 2005-09-15