Rockbox mail archiveSubject: Dircache and talk files
Dircache and talk files
From: Magnus Holmgren <lear_at_algonet.se>
Date: Sat, 08 Oct 2005 10:27:35 +0200
I just happened to notice something that I don't like the look of...
In filetree.c:check_file_thumbnails, the following statements can be found:
while((entry = readdir_cached(dir)) != 0) /* walk directory */
/* terminate the (disposable) name in dir buffer,
this truncates off the ".talk" without needing an extra
entry->d_name[ext_pos] = '\0';
From what I can tell, with the current readdir_cached implementation,
that name isn't disposable any more... It just returns the dircache
entry - if the cache is initialized. Shouldn't readdir_cached always
return a pointer to secondary_entry?
Received on 2005-10-08