From: John Lawrence <blaquestic_at_gmail.com>
Date: Mon, 23 Jan 2006 20:00:14 -0500

about the color wps u posted up. i tried to get the color working, but i
dont know how to patch linus' color patch and the transparency patch. can
anyone help? -John

On 1/23/06, Daniel Stenberg <daniel_at_rockbox.org> wrote:
>
> On Mon, 23 Jan 2006, Kaiet Estrada Gamarra wrote:
>
> > I would like know why that work isn't in the offial Rocbox, and if in
> the
> > future, these will be integrated in Rocbox.
>
> In general, patches aren't applied (yet) because:
>
> 1 - they aren't (yet) good enough
> A - wrong source code style
> B - not working on one or more platforms
> C - breaking the builds
> D - plain wrong use of functions
> E - uses an approach/buttons/menus not deemed "correct" by the dev
> community
> F - others
>
> 2 - no "commit-dev" has had time to commit it
>
> 3 - no dev has yet reviewed it
>
> 4 - no patch has been delivered to Rockbox's patch tracker
>
> The "H300 optimized build" ones often fall into category 4 and all sorts
> of
> category 1. But there's also some 3's and I bet there's a few 2's too...
>
> What you can do to help?
>
> 1 - Make sure the patch is *clean* and make all platforms build
> warning-free
>
> 2 - Follow the CONTRIBUTE guidelines
>
> 3 - Submit the patch to the patch tracker.
>
> 4 - Not to forget: voice your support for particular patches you like and
> think adhere to the 3 steps mentioned before this.
>
> --
> Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/
>
Received on 2006-01-24