From: Will Dyson <will.dyson_at_gmail.com>
Date: Sat, 11 Mar 2006 01:35:25 -0500

It is not safe to pass NULL to dlclose(). At least on unix. I cannot
imagine it is a good idea on windows either.


Index: uisimulator/common/io.c
===================================================================
RCS file: /cvsroot/rockbox/uisimulator/common/io.c,v
retrieving revision 1.28
diff -u -r1.28 io.c
--- uisimulator/common/io.c 2 Mar 2006 01:08:38 -0000 1.28
+++ uisimulator/common/io.c 11 Mar 2006 06:30:36 -0000
_at__at_ -361,7 +361,6 _at__at_
 #else
         DEBUGF("dlopen(%s): %s\n", path, dlerror());
 #endif
- dlclose(*pd);
         return NULL;
     }

_at__at_ -399,7 +398,6 _at__at_
 #else
         DEBUGF("dlopen(%s): %s\n", path, dlerror());
 #endif
- dlclose(*pd);
         return NULL;
     }

--
Will Dyson

Received on 2006-03-11