genlang breaks with less-than and greater-than symbols in quoted strings

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: James Teh <jamie_at_jantrid.net>
Date: Fri, 21 Apr 2006 14:52:02 +1000

Hi all,

In r1.248 of english.lang, line 8492 breaks genlang:
desc: "<All tracks>" entry in tag browser
Running this command:
genlang -o -e=english.lang -t=h300 english.lang
Undefined subroutine &main::All tracks called at ../../tools/genlang line 418, <LANG> line 8493.
I think i have tracked this down to line 318 of genlang:
if(/ *<([^>]*)>/) {
This expression does not check whether the <tag> is outside of a quoted
string. Would a simple fix be to anchor this expression to the start of
the line:
if(/^ *<([^>]*)>/) {
or does this break langv2?

Jamie

-- 
James Teh
Email: jamie_at_jantrid.net
WWW: http://www.jantrid.net/jamie/
MSN Messenger: jamie_at_jantrid.net
Jabber: jteh_at_jabber.org
Yahoo: jcs_teh

Received on 2006-04-21

Rockbox mail archive

genlang breaks with less-than and greater-than symbols in quoted strings