From: James Teh <jamie_at_jantrid.net>
Date: Wed, 26 Apr 2006 09:56:26 +1000

Hi Manuel,

My understanding of the Rockbox code is still very sketchy, so apologies
if this is wrong. However, the edit preset/delete preset menu seems to
be set up with the standard menu code, with an entry in the menu items
struct for edit preset like this:
{ ID2P(LANG_FM_EDIT_PRESET), radio_edit_preset },
If I understand the code correctly, any code using the standard menu
code should voice correctly if a language phrase (i.e. ID2P) is used.
The mono mode setting won't voice, however, because it uses a string constructed at runtime
directly:
{ monomode_menu_string , toggle_mono_mode },
Therefore, LANG_FM_PRESET_EDIT and LANG_FM_PRESET_DELETE should be
voiceable by just adding voice tags, should they not?
The other cases I mentioned are, of course, not possible without adding
extra code.

Jamie

On Tue, Apr 25, 2006 at 06:54:04PM +0200, Manuel Dejonghe wrote:
> Hi Jamie,
>
> as long as you did not find a bug in rockbox that refers to these
> labels which would have been forgotten (I did NOT yet check this) to
> be added to the lang-files, it takes more than simply adding the
> strings to the lang files.
> There is the place in the sourcecode where the screen is set up, and
> the voice-output has to be done there.
> Although, I don't think it's very complicated in that particular case.
>
> As for the plugins, it stays "impossible" at the moment.
>
> ~lImbus

-- 
James Teh
Email: jamie_at_jantrid.net
WWW: http://www.jantrid.net/jamie/
MSN Messenger: jamie_at_jantrid.net
Jabber: jteh_at_jabber.org
Yahoo: jcs_teh

Received on 2006-04-26