From: Jens Arnold <arnold-j_at_t-online.de>
Date: Sun, 15 Mar 2009 10:40:37 +0100

On 14.03.2009, Steve Martin wrote:

> So, here is what I've had to do to get things working with
> the Toshiba MK2431GAH 240gb drive:

> 1. Make the following changes in
> "/usr/src/rockbox/firmware/export/config-ipodvideo.h"

> /* define this if the hard drive uses large physical
> sectors (ATA-7 feature) */ /* and doesn't handle them in
> the drive firmware */ /* MAX_PHYS_SECTOR_SIZE 1024 */
> #define MAX_PHYS_SECTOR_SIZE 4096
> #define HAVE_LBA48

As the comment says, MAX_PHYS_SECTOR_SIZE is only necessary for
drives having large physical sectors *and* not being able to
handle the joining/splitting themselves. So far the only drives
this applies to is the original 80GB ipod video HDD. If this
240GB drive can handle this itself, you'll get better
performance if you *disable* MAX_PHYS_SECTOR_SIZE support in
rockbox.

I think we should improve the handling in the ATA driver. There
are two options:

1) Simple, but somewhat nasty: Check the model, and only enable
   large physical sector handling for the MK8011GAH.
   Easy to implement, but may give false positives (MK8011GAH
  with different firmware) and false negatives (MK4011GAL -
  does that exist?)

2) More complex: Probe the drive by trying a 512 byte transfer.
   If it answers with IDNF, it doesn't handle splitting itself
   and needs rockbox to do it. The question is whether a reset
   returns the drive to normal after that.

Regards, Jens

-------------------------------------------------------------------
List admin: http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox
FAQ: http://www.rockbox.org/twiki/bin/view/Main/GeneralFAQ
Etiquette: http://www.rockbox.org/mail/etiquette.html
Received on 2009-03-15