Rockbox mail archiveSubject: Re: radio fix for iRiver
Re: radio fix for iRiver
From: XavierGr <xaviergr_at_gmail.com>
Date: Mon, 14 Nov 2005 02:13:18 +0200
What do you mean without modifications?
The patch contains only the radio changes.
Also in the new daily build my patch is broken completely due to heave
alteration of the same file.
Do you want me to set up a patch that will manipulate fmr presets with
I could do that, but it will be quite hard to follow if another update is
done to radio.c.
On 14/11/05, Tony Lenox <len0x_at_mail.ru> wrote:
> I will have a look. It would help though if you could make a clean patch
> without other modifications.
> *From:* rockbox-dev-bounces_at_cool.haxx.se [mailto:
> rockbox-dev-bounces_at_cool.haxx.se] *On Behalf Of *XavierGr
> *Sent:* Sunday, November 13, 2005 10:50 PM
> *To:* Rockbox development
> *Subject:* Re: radio fix for iRiver
> Anton, I see that you started a series of changes in radio.c.
> I was wondering if you could add some of the of the saving/loading
> functions that I use in my fm preset patch. This way I think that the radio
> will be better and it will enable users to have multiple preset files for
> different cities, countries.
> Of course this is, if all other devs agree on such changes. Thanks...
> On 13/11/05, Linus Nielsen Feltzing <linus_at_haxx.se > wrote:
> > Anton Oleynikov wrote:
> > > I have a fix for the problem when radio stays on while starting
> > playback of
> > > a file described here (including patch):
> > > http://forums.rockbox.org/index.php?topic=1740.0
> > > Is this a correct way of doing it? If yes, then I can commit the
> > fix...
> > I think that will work just fine. Commit it.
> > Linus
Received on 2005-11-14