Rockbox mail archiveSubject: Re: Simplified and uniform volume handling - asking for opinions
Re: Simplified and uniform volume handling - asking for opinions
From: Jens Arnold <arnold-j_at_t-online.de>
Date: Wed, 07 Dec 2005 08:43:59 +0100
On 06.12.2005, Anton Oleynikov wrote:
> The whole point of my patch was that user finally have
> intelligent bass/volume control that allow him to compare
> sound directly to original iRiver's firmware (meaning user
> doesn't have to manually reduce bass to avoid clipping - this
> behaviour sounds the most reasonable if you have to go for
> just one default option). I agree that some options like
> "adjust current" may be not ideal, but I wasn't the one who
> suggested them...
>>> The whole point of me doing first patch was that second
>> option. It was
>>> extensively discussed in the forum and now that seem to be
>> In the forum perhaps, but not a lot here.
> Jens didn't reply to my original patch email here, did he?
No, I didn't. For one I wasn't around for 3 days. Furthermore,
you put it in a thread started as something completely different
instead of opening a new thread, which doesn't exactly help to
>> And no matter what, it is always considered fine to improve
>> whatever we did before.
> Improve - yes, but completely remove what I've just done
> after not even speak up when asked - its another thing :)
Complete removal would mean to simply revert your work, which I
didn't. I removed all the option code, but not because I think
we shouldn't have these options at all (although I don't see the
need either), but because
(1) I think that 4 different options are overkill, if at all,
a simple on/off should be enough, and
(2) I don't like the way it is implemented. Too much happening
behind the scenes, without feedback.
As for comparing to the iriver firmware - I couldn't care less.
After some initial tinkering I don't use it at all except for
the occasional bootloader update. Imho it's really cumbersome to
use, so not exactly what I'd call a reference for user
Received on 2005-12-07