From: George Styles <ripnetuk_at_gmail.com>
Date: Tue, 21 Feb 2006 11:38:10 +0000

Hi,
Ive been looking at bookmark.c, because the 'do you want to play this
bookmark' doesnt work at present with the H140 remote. You can select the
file, but there is no GUI on the remote, and worse it wont accept a butotn
press on the remote to play the bookmark.

It has a custom input screen (to select play bookmark, delete bookmark,
select bookmark), which only works on the main unit.

I could hack in 100% of what /I/ want by just allowing play on the remote to
select play bookmark. That way, the user would work 'blind' but you could
start a bookmark from the remote. Would Rockbox accept such a half-arsed
patch?

Of course the correct way forward is to implement a generic function similar
to gui_yesno which has more options than yes/no (and a callback for
selecting which bookmark to play). Does such a GUI function already exist
for hooking in??

Alternatively, perhaps the bookmarks should be re-done and presented as a
menu instead of the current screen - it could then list all bookmarks in a
list rather than scrolling through them. Can we have context menu's within
menus for delete etc? or would we need a sub-menu for deleting them?

This would have the advantage of re-using known good code, and IMHO improve
consistency in Rockbox.

Creating bookmarks is fine from the remote.

Any thoughts?


thanks

g
Received on 2006-02-21