Rockbox mail archiveSubject: Re: Track skipping & shuffling cause hard lockups.
Re: Track skipping & shuffling cause hard lockups.
From: Hardeep Sidhu <hardeeps_at_pobox.com>
Date: Mon, 03 Apr 2006 07:01:00 -0700
> OK, the lockup is specific to having _both_ shuffle and repeat-shuffle
> enabled. It's caused by this call in playlist.c, line 2431:
> playlist_start(0, 0);
> It seems extraneous and causes a deadlock in the playback queue system
> - removing it fixes the problem.
Thanks for investigating. I've committed the fix.
> Speaking of repeat-shuffle, I assumed this would work even without
> shuffle on, ie. on the first pass the list plays alphabetically, but
> on subsequent passes it's randomised. However the code only uses it
> if shuffle is also enabled. I think this should be changed.
I was thinking of removing that check as well. If no one disagrees, I
will do so.
Received on 2006-04-03