Rockbox mail archiveSubject: Re: logf enhancements
Re: logf enhancements
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 4 Jun 2006 09:44:57 +1000
postmaster_at_diffenbach.org: welcome to the internet :D as for not
testing/compiling it, i said that this was more for feedback than to
actually be incorporated yet.
RaeNye: thanx, ill fix those typos.
as for it not working, im not sure how often the log is currently
written to, so its quite likely its working but not loggin anything.
im gonna make a test plugin to test it properly, probably today but
On 04/06/06, RaeNye <raenye_at_netvision.net.il> wrote:
> Two corrections:
> 1. #include "logf" should be #include "logf.h" in apps/debug_menu.c
> 2. lvl_codes should be "IANWEUC" instead of "IANIEUC" in
> Also, it didn't patch cleanly against CVS but it was fixable.
> Failed hunks: #1/5 in apps/logfdisp.c, #1/3 in firmware/logf.c
> After fixing these, I checked functionality on my X5.
> It neither crashed nor worked; i.e., .rockbox/syslog.log wasn't created and
> even when I touch'ed it, it didn't fill with contents.
> Note: using the 'dump logf' menu option did cause a HDD reaction.
> -----Original Message-----
> From: rockbox-dev-bounces_at_cool.haxx.se
> [mailto:rockbox-dev-bounces_at_cool.haxx.se] On Behalf Of Jonathan Gordon
> Sent: Saturday, June 03, 2006 3:53 PM
> To: Rockbox development
> Subject: logf enhancements
> last week i got the idea of getting logf used in the standard build in the
> hope that it could be used to trace some of the painful bugs (i.e wierd
> playback issues), so iv started work on making logf a bit nicer,,, so ive
> attached a patch with the my work so far hopefully to get some feedback...
> (i know we r in the freeze, but i rekon if this is used it might help speed
> up the freeze....) stuff ive changed so far:
> removed some ROCKBOX_HAS_LOGF defines (u should still define it if u want to
> test out the patch coz it might not compile without that defined just yet)
> added syslogf which is supposed to replace logf. the difference is syslog
> allows a level for the log message.
> the level is a combination of the subsystem (main thread, playback, etc),
> and a error level warning, error, info, etc).
> the idea with the levels is that errors with less severity then your choice
> wont get logged, and even if the severity is higher than your level, it will
> only get logged if its one of the sub-systems your monitoring..
> so, all that is left to do is remove the rest of the ROCKBOX_HAS_LOGF
> defines, add a nice log viewer and get the rest of rockbox using it...
> so yeah... whatcha think?
Received on 2006-06-04