Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: A nasty inefficieny in file.c?

Re: A nasty inefficieny in file.c?

From: Magnus Holmgren <lear_at_algonet.se>
Date: Fri, 14 Jul 2006 16:40:08 +0200

Jens Arnold wrote:

> Another thought:
>
> Are you listening to mp3? Iirc Slasheri said that the id3
> parser is one such example of inefficiency as it reads
> byte-by-byte....

The id3 parser should read frame by frame, at least according to a quick
look at the code.

Other cases that do read char by char include the WPS reader and the
config file reader (both using misc.c:read_line). Maybe the WPS reader
is the main cause of these one byte reads in that short test run...

   Magnus
Received on 2006-07-14

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew