Rockbox mail archiveSubject: Re: A nasty inefficieny in file.c?
Re: A nasty inefficieny in file.c?
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sat, 15 Jul 2006 18:20:45 +1000
On 15/07/06, Magnus Holmgren <lear_at_algonet.se> wrote:
> Jens Arnold wrote:
> > Another thought:
> > Are you listening to mp3? Iirc Slasheri said that the id3
> > parser is one such example of inefficiency as it reads
> > byte-by-byte....
> The id3 parser should read frame by frame, at least according to a quick
> look at the code.
> Other cases that do read char by char include the WPS reader and the
> config file reader (both using misc.c:read_line). Maybe the WPS reader
> is the main cause of these one byte reads in that short test run...
shouldnt that read_line function be changed then to read X instead of
1 byte and then either cache the extra bytes read or move the fd back
to the end of the new line?
Received on 2006-07-15