|
Rockbox mail archiveSubject: Re: A nasty inefficieny in file.c?Re: A nasty inefficieny in file.c?
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sat, 15 Jul 2006 19:20:38 +1000 grr, i cant get libsdl installed and that code definatly is no good, so dont bother trying yet :p to limit the distance it has to seek back would it be better to read the smaller of MAX_PATH and buffer_size untill either the buffer is full or we hit a new line? instead of just reading the full buffer size? On 15/07/06, Jonathan Gordon <jdgordy_at_gmail.com> wrote: > On 15/07/06, Linus Nielsen Feltzing <linus_at_haxx.se> wrote: > > Jonathan Gordon wrote: > > > // move the fd back to AFTER the \n if needed > > > if (!errno) > > > lseek(fd,num_read-count+1,SEEK_CUR); > > > > That could be a really lengthy operation if it crosses a sector boundary. > > > but it that worse than doing lots of 1 byte reads? > > Linus > > > Received on 2006-07-15 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |