|
Rockbox mail archiveSubject: Re: A nasty inefficieny in file.c?Re: A nasty inefficieny in file.c?
From: Linus Nielsen Feltzing <linus_at_haxx.se>
Date: Tue, 18 Jul 2006 07:15:13 +0200 Bill Janssen wrote: > Why doesn't the sector buffer in the "readwrite" function already do > the necessary buffering? The sector buffer in the readwrite function does the buffering, and it works perfectly fine. The "nasty inefficiency" in this special case is that readline reads 1 byte at a time from the sector buffer, calling memcpy to copy a single byte. Again, I don't think it's a big deal, since readline is used to read config files, highscores and stuff, hardly time critical. Linus Received on 2006-07-18 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |