Rockbox mail archiveSubject: Re: Reviewers and committer for talkative RB
Re: Reviewers and committer for talkative RB
From: Will Robertson <aliask_at_gmail.com>
Date: Wed, 1 Nov 2006 17:43:08 +1100
I've been advocating these patches on IRC, but I haven't actually gotten
around to looking at them myself.
I've made a point to actually compile a build with the splash screen
enhancements, and I'll post back my thoughts once I've done this.
Keep up the great work :)
On 11/1/06, Paul Louden <paulthenerd_at_gmail.com> wrote:
> Often what happens is that the developers who are capable of committing
> patches are just very busy people. They see a patch of interest, think "I'll
> look through that later, when I have time" and then proceed not to really
> have time for several days, by which time it has become lost in a pile of
> plenty of things to look at.
> One of the most helpful things you can do is to try to visit the IRC
> channel, and ask about specific patches and whether any of the developers
> can offer feedback as to whether anything is preventing your patch from
> On 11/1/06, Stéphane Doyon <s.doyon_at_videotron.ca> wrote:
> > On Thu, 12 Oct 2006, Linus Nielsen Feltzing wrote:
> > >> Anyway I'd like to work on some of that, in what little spare time I
> > have
> > >> :-). I just wanted to make sure there's no actual opposition to this
> > sort
> > >> of stuff.
> > >
> > > Absolutely not! We are delighted to have a coder that gives these
> > things some
> > > attention.
> > Thanks for all the responses I got on this thread. However, when I asked
> > whether there was any interest for improved voice feedback, I should
> > have
> > asked whether there was any such interest AMONG DEVELOPERS :-). I have
> > received almost no feedback to any of my patches. Is there anything I
> > can
> > do to change that?
> > It would be motivating to get some of this stuff committed.
> > P#6159 Add voice to roughly 100 splashe screens and yesno menus
> > I'm pretty much satisfied with that one. It's nice to be told things
> > like
> > "Directory buffer full", "Really delete", "Erase dynamic playlist?",
> > etc...
> > P#6171 Talking quick screen
> > Seems to work fine.
> > P#6138 Be more talkative in info menu
> > Pretty trivial stuff...
> > P#6236 talk mp3 clip fallback
> > This one did receive comments. I have rearranged the existing settings
> > as
> > suggested. Works for me.
> > P#6237 Shorter hover delay for talk mp3 clips
> > Feedback and testing would be nice.
> > P#6239 Lack of protection against reuse of p_thumbnail: tentative fix
> > Works for me.
> > P#6240 Improved voice feedback in bookmark selection
> > Works for me. Seems to me the "most recent bookmarks" list is pretty
> > much
> > useless for blind users without this.
> > P#6271 Say something when entering an empty directory
> > Just posted that one, seems to work.
> > P#6188 Tracklock: audio book mode, avoid unintentional track skips
> > That's the one preventing inadvertent track skips, such as for audio
> > books. I'm never losing my place anymore. I would like to know what
> > others
> > think about the way it's done though. Also it's incomplete: missing key
> > mappings and visual feedback.
> > I also have this one that's not voice / accessibility related:
> > P#6238 A few more intuitive key mappings for X5
> > Do these make sense?
> > Thanks
> > --
> > Stéphane Doyon
> > <s.doyon_at_videotron.ca>
> > http://pages.infinit.net/sdoyon/
Received on 2006-11-01