Rockbox mail archiveSubject: Re: how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?
Re: how should ata_idle_notify handle SYS_USBCONNECTED and SYS_SHUTDOWN?
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 8 Nov 2006 10:55:34 +1100
On 08/11/06, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> Are you sure?
> The problem is with callback owners who dont have thier own threads
> (i.e the delayed settings saving). unless the ata thread calls that
> callback it wont happen.
> Unless its no big deal if settings are not saved on shutdown/usb?
hmm... currently the ata_flush() is called in powermgnt.c to deal with
this, so i guess ill call the settings_save callback explicitly there.
> On 08/11/06, Linus Nielsen Feltzing <linus_at_haxx.se> wrote:
> > Jonathan Gordon wrote:
> > > hey,
> > > I'm pretty sure that the idle notify callbacks should be called for
> > > these 2 events.
> > I'm not. Let the callback owners deal with that.
> > Linus
Received on 2006-11-08