Rockbox mail archiveSubject: Re: using config.cfg instead of config block
Re: using config.cfg instead of config block
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Thu, 16 Nov 2006 00:21:15 +1100
I found the bug, it was the menu callback for the sound settings menu
setting low_latency on when it was asking to be shown instead of when
it is being entered.
So, now its working it is pretty much ready for review, especially the
- non-volatile settings probably need better handling
- middle of menu.c, I have to undef P2STR and P2ID and redefine them
or i get compile errors?
- dumping the config from the default_event_handler() ?
- I have a FIXME next to the rectrigger() call and im not sure why
(all recording stuff probably needs fixing/checking
- the entire settings_list needs double checking (which i'll probably
do tomorrow unless beaten)
- anything else I cant think of right now.
I've attached the patch because I don't think its quite ready for FS
and the wiki is irritating.
Please comment so I know what needs fixing.
On 15/11/06, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> I found the problem... well sort of...
> It turns out there is a problem with how dynamic menus are handled.
> The way it is supposed to work is that if there is a chance that a
> menu should not be displayed then it is given a callback, and return a
> special value if the item should not be shown...
> now, there is no problem if the callbacks are skipped, (commenting out
> menu.c line 429-439 everything works correctly, except no dynamic
> So, its either something blatantly obvious but I've been staring at it
> for too long and miss it, or its something wierd and im hoping an
> extra pair of eyes (or more?) would be able to see the problem.
> Attached is the new patch.
> Also, still waiting on a response to weather useing
> default_event_handler() to dump the config file is OK.