From: <midkay_at_gmail.com>
Date: Thu, 4 Jan 2007 06:51:01 -0800

Just want to point out that volume should not be changed from the current method because some people use 'max' and 'min/mute' bitmaps, and they won't work right otherwise.

Battery change sounds fine though. :)

Zakk

<midkay_at_gmail.com>

-----Original Message-----
From: "Linus Nielsen Feltzing" <linus_at_haxx.se>
To: "Rockbox development" <rockbox-dev_at_cool.haxx.se>
Sent: 1/4/2007 4:18 AM
Subject: Re: Battery and volume level display in WPS

Tobias Heimann wrote:
> IMHO it would be more logical to spread the highest interval as the
> other ones, e.g. using:
>
> int l = MIN(battery_level(), 99);
> ...
> *intval = limit * l / 100 + 1 + 1;
>
> The volume display interval has the same issue btw.

Sounds OK to me. Care to submit a patch?

Linus
.
Received on 2007-01-04