Rockbox mail archive
Subject: Re: barrywardell: r12838 - trunk/firmware/commonRe: barrywardell: r12838 - trunk/firmware/common
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 19 Mar 2007 20:58:31 +0100
Barry Wardell wrote:
>> Should it really modify the input string like that? What if it is in
>> flash? (Might not be a problem as currently used, but...)
>>
>> Magnus
>>
>>
> Good point. Would this be a better way to do it:
<...>
> _at__at_ -160,7 +161,7 _at__at_
> while (width-- > 0 && ok)
> ok=push(userp, pad);
> }
> - while (*str != '\0' && ok)
> + while (*str != '\0' && ok && precision--)
> ok=push(userp, *str++);
> }
Yes, that looks like a good solution.
Magnus
Received on 2007-03-19
Date: Mon, 19 Mar 2007 20:58:31 +0100
Barry Wardell wrote:
>> Should it really modify the input string like that? What if it is in
>> flash? (Might not be a problem as currently used, but...)
>>
>> Magnus
>>
>>
> Good point. Would this be a better way to do it:
<...>
> _at__at_ -160,7 +161,7 _at__at_
> while (width-- > 0 && ok)
> ok=push(userp, pad);
> }
> - while (*str != '\0' && ok)
> + while (*str != '\0' && ok && precision--)
> ok=push(userp, *str++);
> }
Yes, that looks like a good solution.
Magnus
Received on 2007-03-19
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy