Rockbox mail archiveSubject: Re: last points before loadable icons can be commited
Re: last points before loadable icons can be commited
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Mon, 16 Apr 2007 10:05:29 +1000
On 16/04/07, Dominik Riebeling <dominik.riebeling_at_gmail.com> wrote:
> On 4/15/07, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> > Firstly, does anyone (well... committers really) object to the patch ? (FS#7013)
> I haven't looked into it much so just a few comments of mine ...
> > The way (i think) I'd like it done is to move the icon setting out of
> > viewers.config and leave it completely up to themers to choose which
> > icon is used by which plugin. (so if we do this, we have to supply a
> > config file for the default set, which is fine by me)
> How about keeping the current way the viewer icons are stated in
> viewers.config as a fallback? Or is this not feasible due to added
> complexity and code size?
well, this is how its done atm, the idea was to move al theming out of
the file, its easy to loave in as a fallback
> How about binary sizes with the current version? I have seen some
> values in the comments of that task but it looks like it changed a bit
> since then. Can you provide some updated values or are they still
> similar to that ones?
the sizes at the end of the tracker is still roughly correct
Received on 2007-04-16