|
Rockbox mail archiveSubject: Re: christian: r13620 - in trunk/firmware: drivers/audio exportRe: christian: r13620 - in trunk/firmware: drivers/audio export
From: Christian Gmeiner <christian.gmeiner_at_gmail.com>
Date: Tue, 12 Jun 2007 11:39:49 +0200 2007/6/12, Dave Chapman <dave_at_dchapman.com>: > mailer_at_svn.rockbox.org wrote: > > Modified: trunk/firmware/drivers/audio/tlv320.c > > =================================================================== > > --- trunk/firmware/drivers/audio/tlv320.c 2007-06-11 13:32:29 UTC (rev 13619) > > +++ trunk/firmware/drivers/audio/tlv320.c 2007-06-11 23:39:07 UTC (rev 13620) > > _at__at_ -219,10 +219,10 _at__at_ > > } > > > > /** > > - * Mute (mute=true) or enable sound (mute=false) > > + * Mute (mute=1) or enable sound (mute=0) > > * > > */ > > -void audiohw_mute(bool mute) > > +void audiohw_mute(int mute) > > Was there a reason for making this parameter an int in all drivers, > rather than bool? > > I realise that only the tlv320 driver used bool before your commit, but > that would seem clearer IMO. I have choosen an int, because more driver used and int before my changes, but it is also no problem to change it to a bool version. Will do the change in my next commit - today or tomorrow. Greets, Christian Received on 2007-06-12 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |