Rockbox mail archiveSubject: uncommitable patches..?
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 12 Aug 2007 15:48:13 +1000
So, during the cleanup week I came across lots of patches which I
don't think are ever going to be committed (for various reasons), but
some of them are fairly popular almost the custom builders and so I
didn't want to close them so they can be maintained.
I thought we should probably come up with what to do about them.
My suggestion is create another group in FS for them (not a category,
an actual group like patches, bugs, uncommitable patches). my
reasoning is that just having that group doesn't mean we support the
patch at all, but it does keep them in a central place, as apposed to
having them split over 15 forums and wikis.
So, here is a quick list of the patches which I think fall into this
group: (my reason for closing/never committing is in the brackets)
6474 - y-margin reset in gui_list_draw (viewports)
2954 - Scrolling text margin for the wps (viewports)
2653 - added one-click-to-insert functionality in file tree (custom buttons)
2999 - Reads USLT Lyrics from id3->txt file displays with view... (MoB)
3045 - Album art display on WPS (MoB)
4733 - Multifont (viewports)
4755 - Wikipedia (useless?)
5526 - Ipod scroll acceleration API (should be rejected because we now
have a scroll api in svn)
5555 - Record Button Configuration (custom buttons)
5594 - Ipod scroll acceleration patch (dupe 5526?)
5886 - Rec button to go to playlist viewer and recording scree... (buttons)
5898 - Custom Display Width for 16Bitmap LCDs (viewports)
5899 - Custom List/Menu x/y coordinates and width (viewports)
5900 - Custom WPS Line with x/y/width coordinates and font fac... (viewports)
5907- WPS partial line scroll (viewports)
So? Whats everyones opinion on these? (also, Jens, viewports....? :D )
Received on 2007-08-12