|
Rockbox mail archiveSubject: Re: gui_synclist_do_button() changesRe: gui_synclist_do_button() changes
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Mon, 17 Sep 2007 13:35:06 +1000 On 17/09/2007, Matthias Mohr <Matthias_at_mohrenclan.de> wrote: > Hi Jonathan, > > look at the following lines (in apps/tree.c): > ----------------------------------------------------------------------------------------- > _at__at_ -640,9 +636,11 _at__at_ > if ((*tc.dirfilter == SHOW_ID3DB && tc.dirlevel == 0) || > ((*tc.dirfilter != SHOW_ID3DB && !strcmp(currdir,"/")))) > { > - if (returned_button == ACTION_STD_CANCEL) > +#ifdef HAVE_LCD_BITMAP > + if (oldbutton == ACTION_TREE_PGLEFT) > break; > else > +#endif > return GO_TO_ROOT; > } > > ----------------------------------------------------------------------------------------- > The old code does a break in case of "ACTION_STD_CANCEL" and > otherwise it returns GO_TO_ROOT. > > In your new code it depends if HAVE_LCD_BITMAP has been set. > If it is set, it breaks in case of "ACTION_TREE_PGLEFT" otherwise it > returns GO_TO_ROOT. > If HAVE_LCD_BITMAP is not set, it always returns GO_TO_ROOT > > Was this your intention to remove the check for "ACTION_STD_CANCEL"? > > > Despite the above I can't find anything unusual - for me it looks fine > > with regards, > Matthias > that snippet could be cleaned up a bit (the HAVE_LCD_BITMAP was put in to use a different action and I forgot to remove it), but I just checked the sim with this and svn and I get the same behaviour... So I tihnk its OK. Can someone with a player please check? Received on 2007-09-17 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |