Rockbox mail archiveSubject: Re: Plugin button actions
Re: Plugin button actions
From: Marianne Arnold <m.arnold_at_infocity.de>
Date: Sat, 27 Oct 2007 09:08:29 +0200
sorry to dig up my own topic but I got no response so far and came across another issue now and wished there was already some discussion and a decision, because I want to know how to proceed.
In addition to the original issue as described in http://www.rockbox.org/mail/archive/rockbox-dev-archive-2007-10/0007.shtml (for those who don't have the original mail anymore) I now have another, more specific problem.
Recently there was a report of metronome not working properly on c200- you can "tap" the beat but not "play" it back (a recent change divided this into two different things). I thought I could have a look at metronome.c and saw... 57 lines of action and action context definitions! While dealing with metronome I noticed that the entire plugin was now missing in the Ondio (Archos) builds. Skimming through the latest related commits I found the one that disabled it for Archos and then the one that introduced the weird action context struct: http://svn.rockbox.org/viewvc.cgi/trunk/apps/plugins/metronome.c?r1=14051&r2=14050&pathrev=14051 . The new lines define 2 for some targets even 3 contexts? How should that work? Conflicts are to be expected and so it was no surprise when I found out that the plugin can only be halfway operated on Ondio, after enabling it again. Later I've also been told that ever since moving this plugin to button action it was not usable on the Player (even
without the above changes when it was simpler) - with no idea how to define actions to make it work again.
Seeing all these issues with the controls and not the faintest clue how to solve them, especially with this mix of action defines, I'd like suggest to return to simple button defines per keypad at least in this case. I would be willing to try and do it myself - but before starting I'd like to know if this is a wanted change so that it's not a waste of time.
I'm open to suggestions but I really think this topic needs some decision, so please discuss.
Received on 2007-10-27