Rockbox mail archiveSubject: Re: Getting the Creative Zen Vision M code into SVN
Re: Getting the Creative Zen Vision M code into SVN
From: Maurus <mcuelenaere_at_gmail.com>
Date: Mon, 7 Apr 2008 17:39:13 +0200
I just want to mention something about those unconditional changes in code:
most of this code is either test code which will get removed or
'conditionaled' in the future or it (referring to system-dm320.c) resets
values to it's default value i.e. TIMER0 and TIMER1, IRQ's priorities, etc..
TIMER0 and TIMER1 are set up as tick task and as normal timer, so the change
in system-dm320.c shouldn't do anything harmful.
Most other changes are related like this one so I think not really much
affects the mrobe500 port (apart from maybe the DSP changes, which are again
test code; especially since Catalin now figured out how to get audio on the
DSP so it is more or less obsolete)
And of course the usb.c changes shouldn't be there (//#ifdef BOOTLOADER), as
they are (again) test code.
So for the big picture, I believe most ZVM-specific code is ready for
committing (especially the tools/scramble code).
On Mon, Apr 7, 2008 at 7:49 AM, Daniel Stenberg <daniel_at_rockbox.org> wrote:
> On Sun, 6 Apr 2008, Mike . wrote:
> Looking through FS#8686, there is a lot of code for the Zen port as well
> > as some code thats probably useful in general to the m:robe 500 port as well
> > since they share the same SOC. A little was added to SVN last month, but
> > since then another 200kB worth has accumulated without anyone else
> > commenting.
> > Perhaps we should think about giving Maurus Cuelenaere SVN access so
> > that all of this can be kept in sync with the other TMS320 port and the USB
> > stack.
> I'm not sure that's the reason for the patch not having gotten in yet.
> I did the initial commits of a few parts of his work that was clearly only
> touching stuff that is ZVM-unique. I'm sure we can go over it again and
> commit large chunks of it that have no risk of colliding with other ports.
> But, with the little disclaimer that I haven't looked at it lately, the
> patch did contain several unconditional changes to generic code that affects
> the life of at least the mrobe500 port but possibly also others and such
> changes need to be carefully considered (by people faimilar with the ports)
> and tested on the affected targets before we commit them.
> But of course, giving him SVN commit access will let him start committing
> things and gradually allow his external patch to shrink and vanish over
> Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/
-- Mvg, Cuelenaere MaurusReceived on 2008-04-07