From: Dave Chapman <dave_at_dchapman.com>
Date: Thu, 05 Jun 2008 23:52:18 +0100

mailer_at_svn.rockbox.org wrote:
> Date: 2008-06-05 10:20:39 +0200 (Thu, 05 Jun 2008)
> New Revision: 17690
>
> Log Message:
> make %V a little simpler. only the x and y values have to be specified now (i.e %V|0|0|||||| )
> default values are as follows:
> width - lcd width - the x value
> height - lcd height - y value
> font - user font
> fg colour - the themes fg colour on 16bit targets, black on greyscale targets
> bg colour - the themes bg colour on 16bit targets, white on greyscale targets

IMO it's debatable whether this makes things simpler, it's adding code
complexity, and just saves WPS authors a little typing (which they do once).

Given the heavy use of bitmaps (and backdrops) in most WPSs, I'm not
convinced that many themes are capable of looking reasonable with any
choice of colour, or that users want the ability to easily change the
fg/bg colours of text in a WPS.

So for (IMO) a very minimal gain, we now need to worry about corner
cases and more ways for WPS authors and/or users to break things.

e.g. when the user changes the fg/bg colour in the settings menu, the
WPS viewports aren't updated with those changes (until the WPS is
reloaded). Not a big issue, but it makes this a partly working feature.

It also makes the %V syntax inconsistent with the other WPS tags - you
have to include the | separator around optional values.

If I'm reading the code correctly, you've removed some of the error
checking in the wps parser. For example if a WPS author types a colour
incorrectly (e.g. only types 5 hex digits instead of 6), the wps parser
will now happily accept it (defaulting to the appropriate theme colour),
rather than giving a parser error. "missing" and "invalid" are two
different things.

Overall, as more and more of Rockbox becomes themable, I think we just
need to accept that users won't be able to change things via the menus -
they will need to modify the theme files.

Dave.
Received on 2008-06-06