Rockbox mail archiveSubject: Re: Powermanagement rework
Re: Powermanagement rework
From: Michael Sevakis <jethead71_at_sbcglobal.net>
Date: Mon, 18 Aug 2008 04:56:48 -0400
> 3) There's a huge chunk of code (charging_algorithm_big_step) that
> only gets used when CHARGING_CONTROL is defined. This seems to be
> some kind of -dV/dt charging algorithm.
> Can't we move this to a separate file?
> We could (for example) move specific charging algorithms into
> separate files and put their state machines into a charging_state()
> function that is called from the main power thread.
> 4) If CHARGING_CONTROL really just means a -dV/dt charging algorithm,
> shouldn't we rename it like that?
> Kind regards,
The big/small step portions weren't intended to imply anything but the
minute vs. 1/2 second interval operations. The work on Gigabeat S uses them
for entirely different purposes and they're contained in a taget-specific
file. I know it's not in SVN yet but the framework in place is intended for
greater purpose. Removing that would probably mean it will get reintroduced
anyway in some manner.
Yeah, I've been out of the loop for awhile but I had to take a different
path out of nescessity and I'm sure I'll meet back up soon. Nothing bad--
Received on 2008-08-18