dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Patch review

Re: Patch review

From: Marc Guay <>
Date: Thu, 2 Oct 2008 10:00:10 -0400

> I can imagine though, that it'd be rather time consuming for the people
> involved.

I think that depends on the patch, the problems, the people involved,
etc, etc. For all we know, there could be a great patch in the
tracker that only needs a few tweaks before it's ready to go in. Or
conversely, there could be one that is universally deemed "not worthy"
and can be closed immediately. I think in most cases, there are
certain people who know a lot about the state of the patch - it's just
a matter of having that information shared with everyone else in this
type of focussed scenerio and seeing where it leads.

I'd like to volunteer as note-taker unless someone else is superkeen
on it. Also, I agree that the "POTW: FS#1234" mailing list suggestion
box is a decent-enough way to make a pile of possibles. Of course the
problem then is deciding on which one to review that particular week,
but I'm sure a quick "how about this one?" "sure" "sure" "whatever!"
will do.

Received on 2008-10-02

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy