dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Patch review

Re: Patch review

From: Paul Louden <>
Date: Fri, 03 Oct 2008 03:35:00 -0500

pondlife wrote:
> Hi all,
> From my (limited) perspective, another issue is that contributors don't
> always have the time (or inclination) to complete a patch once it's
> "working" (i.e. good enough for them, but not suitable for SVN).
> I'm very happy to review and comment on patches that interest me, but I
> rarely have enough spare time to get coding (and this applies to many devs,
> I suspect).
> So.. is there any way we can encourage contributors to finish the job?
> pondlife
> p.s. I'm trying desperately to make this sound positive!
That's more or less what my "areas of focus" idea was about. If we say
"The goal for 3.6 is to have better recording functionality" we can then
filter the patch tracker for recording patches, go to them, and say
"Hey, we'd really like to have your feature in for the release, but X
still needs fixed."

I think this is much more encouraging than the usual "Well, X is still
wrong with it, so it won't be committed." I think people will be
energized to hear "We want to include your code specifically for this
Received on 2008-10-03

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy