Rockbox mail archiveSubject: Re: A Rockbox commit offer!
Re: A Rockbox commit offer!
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 28 Oct 2008 11:24:48 +0100 (CET)
On Tue, 28 Oct 2008, Rafaël Carré wrote:
> Ok, is there any other guidelines I should follow which are not mentioned in
> docs/CONTRIBUTING ?
We've tried to keep that up-to-date with what the practises are, but I'm sure
we've missed out a few things. In general it isn't that hard and if there is
anything in doubt you can often just check how others are doing it elsewhere.
> I am thinking of systematic pre-commit review for example.
There's no system for this. All committers are trusted enough to be able to do
this at their own discretion. If you are in doubt, asking and checking with
the crowd before a commit is never wrong.
If you disagree or have problems with someone else's commit you can always
bring the subject to the list after the fact or if it's "just" a bug someone
else did you can just fix it in a subsequent commit.
-- / daniel.haxx.seReceived on 2008-10-28