Rockbox mail archiveSubject: Re: kugel: r19826 - trunk/wps
Re: kugel: r19826 - trunk/wps
From: Jens Arnold <arnold-j_at_t-online.de>
Date: Sun, 25 Jan 2009 10:29:36 +0100
On 24.01.2009, Dominik Riebeling wrote:
> On Sat, Jan 24, 2009 at 5:02 PM, Thomas Martitz
> <thomas.martitz_at_fhtw-berlin.de> wrote:
>> Fonts are part of a theme, as designed by the author. A theme
>> without working font is just as broken as if would show ...
> We intentionally (!) did that for several years, and that was
> agreed upon. While I agree that we shouldn't ship themes with
We need to separate two issues here:
1) wpsbuld.pl had several bugs. One was to not check for plain
"Font:", fixed by Thomas, which made it include too little.
This also caused that only the font for cabbiev2 was
included, which may give the impression it was intended.
It was not, it was just a coincidence. Fixing that bug
uncovered another bug, which made wpsbuild include too much
in some other cases. Not just fonts, but also icon sets and
backdrops. See r19829.
2) Do we want to include several themes or just the default?
Atm we have a few "privileged" themes, those in SVN, and
we're shipping them in the basic installation. Those themes
should of course be shipped in a working state, without
requiring extra downloads. The question is whether we
should stop doing this.
*Imo* we should drop the extra themes from the distribution, but
*only* once the theme site is online (hint hint). Then the
"privileged" themes should be removed from SVN as well.
Providing an extras pack is problematic, because that pack would
be target specific, unlike the font pack.
Received on 2009-01-25