Rockbox mail archiveSubject: Re: kugel: r19826 - trunk/wps
Re: kugel: r19826 - trunk/wps
From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Sun, 25 Jan 2009 16:21:52 +0100
On Sun, Jan 25, 2009 at 10:29 AM, Jens Arnold <arnold-j_at_t-online.de> wrote:
> On 24.01.2009, Dominik Riebeling wrote:
> 1) wpsbuld.pl had several bugs. One was to not check for plain
> "Font:", fixed by Thomas, which made it include too little.
> This also caused that only the font for cabbiev2 was
> included, which may give the impression it was intended.
> It was not, it was just a coincidence. Fixing that bug
I remember things somewhat different here. When the fonts were moved
out of rockbox.zip (r9902) we already were shipping themes so they
were intentionally broken. Interestingly the change that made
wpsbuild.pl also copy the fonts (r16125), done in preparation to
change to default theme to Cabbie, talks about only two themes being
affected though we had more than two themes in svn that time. This at
least somewhat implies that it was intentional to not copy the fonts
for all themes.
> *Imo* we should drop the extra themes from the distribution, but
> *only* once the theme site is online (hint hint). Then the
> "privileged" themes should be removed from SVN as well.
We could use this to create a somewhat static themes page for now that
only contains those themes stripped out of svn. That would have the
advantage that (finally) users won't see an error anymore when trying
to install themes with Rockbox Utility. Maybe for that even the old
theme site code could be reused. Of course this would be only a
temporary solution until the theme site finally gets finished.
> Providing an extras pack is problematic, because that pack would
> be target specific, unlike the font pack.
Why is this problematic? We have target specific builds, manuals,
voice files. I don't see why another target specific package would be
problematic here -- it's "just" a bit of additional work.
Received on 2009-01-25