|
Rockbox mail archiveSubject: Re: kugel: r21229 - trunk/firmware/exportRe: kugel: r21229 - trunk/firmware/export
From: Rafaël Carré <rafael.carre_at_gmail.com>
Date: Tue, 9 Jun 2009 03:20:14 +0200 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le Tue, 9 Jun 2009 01:54:57 +0200, mailer_at_svn.rockbox.org a écrit : > Date: 2009-06-09 01:54:56 +0200 (Tue, 09 Jun 2009) > New Revision: 21229 > > Log Message: > Use the AMS_LOWMEM define to indicate memory size as the .lds files > do in config.h too. > > Modified: > trunk/firmware/export/config.h > > Modified: trunk/firmware/export/config.h > =================================================================== > --- trunk/firmware/export/config.h 2009-06-08 23:05:33 UTC > (rev 21228) +++ trunk/firmware/export/config.h 2009-06-08 > 23:54:56 UTC (rev 21229) @@ -636,8 +636,8 @@ > (((CONFIG_CPU == SH7034) && !defined(PLUGIN)) || /* SH1 archos: > core only */ \ defined(CPU_COLDFIRE) || /* Coldfire: core, plugins, > codecs */ \ defined(CPU_PP) || /* PortalPlayer: core, plugins, > codecs */ \ > - (CONFIG_CPU == AS3525 && MEMORYSIZE > 2) || /* AS3525 +2MB: > core, plugins, codecs */ \ > - (CONFIG_CPU == AS3525 && MEMORYSIZE <= 2 && !defined(PLUGIN) > && !defined(CODEC)) || /* AS3525 2MB:core only */ \ > + (CONFIG_CPU == AS3525 && !defined(AMS_LOWMEM)) || /* AS3525 > +2MB: core, plugins, codecs */ \ > + (CONFIG_CPU == AS3525 && defined(AMS_LOWMEM) && !defined(PLUGIN) > && !defined(CODEC)) || /* AS3525 2MB:core only */ \ (CONFIG_CPU == > PNX0101) || \ (CONFIG_CPU == S5L8700)) /* Samsung S5L8700: core, > plugins, codecs */ #define ICODE_ATTR __attribute__ > ((section(".icode"))) AMS_LOWMEM is defined in cpu.h, and not picked up by config.h , so I suggest the define should move into config-*.h specific files - -- Rafaël Carré -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkotuM4ACgkQYWCeGMCv8Q9LVgCfZhZNsj7J6agNpwoQ6fMzPcKs 1V4AoOAtHt/aS93u2rXANjqNnZ0l1wg4 =Xq90 -----END PGP SIGNATURE----- Received on 2009-06-09 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |