Rockbox mail archive
Subject: Re: For committal: morse menu patch
Re: For committal: morse menu patch
2009/6/15 David Johnston <david_at_pinkandaint.com>:
> Just to make everything totally clear, I'm suggesting this patch to
> add to SVN. Comments? Or, is there anything else I need to do to
> make this more likely to happen?
> On Mon, Jun 15, 2009 at 9:13 AM, David Johnston<david_at_pinkandaint.com> wrote:
>> I just put up a new patch, my first forray into RB development. It's
>> pretty straigtforward, simply adding an entry to the menu system to
>> set whether the user wants to use the morse code input screen rather
>> than the standard one. I think it would be a good addition to the
>> codebase, since it creates a more intuitive way to switch screens, as
>> well as saving the user's preference of which screen to use across
>> I would welcome feedback on functionality as well as menu item text
>> and placement. So far I've only tested it on h120 but I imagine there
>> would be no trouble compiling it for other platforms. I made an
>> effort to follow all the necessary precautions with conditional
>> compiling and so on.
>> Below is the official description in the Flyspray entry
>> This patch adds an entry to the settings menus to set whether the user
>> wants to use the morse code text input screen rather than the main
>> keyboard screen. An entry in the general_settings struct now holds the
>> current morse input bool.
>> As a result of this change, whenever the user changes between the
>> morse and standard text input screens -- either through the menu or
>> the key combo while inputting text -- Rockbox will remember that
>> setting across sessions. This makes the menu item a somewhat redundant
>> feature, but still valuable since it doesn't require remembering an
>> obscure key combination to change text input style.
>> I applied this patch to revision 21293, but should be generally applicable.
have patience.... also, if you look at the patch tracker you will
notice many hundreds of patches that dont get commited...
Received on 2009-06-16
Page was last modified "Jan 10 2012" The Rockbox Crew