|
Rockbox mail archiveSubject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Mon, 29 Jun 2009 18:26:08 +0200 Jonathan Gordon wrote: > > > 2009/6/29 Thomas Martitz <thomas.martitz_at_student.htw-berlin.de > <mailto:thomas.martitz_at_student.htw-berlin.de>> > > Am Mo, 29.06.2009, 11:53, schrieb Marianne Arnold: > > Until we would mark a loaded theme as modified (if it is) I > don't think we > > should pretend an accuracy that isn't there - just highlight the > first > > thing in the list like it is now and be done with it. To be > honest, I'm > > not sure if it's worth the trouble and complication to track > those changes > > and "mark as modified" at all. > > > > It shouldn't be very complicated. We already know what settings > are theme > settings (for the "Save theme settings" menu option). > > Changing any of those would mark a global flag as dirty. Loading a cfg > from the themes menu would reset it. > > If dirty is set we could do something like showing the last > loaded, but > with a "*" at the end (for modified), or show a special menu entry > like > "<modified: based off theme XXX>") > > Best regards. > > > That doesnt solve the problem where 2 themes are loaded and both work > fine together... i.e on the hxxx's you could load a .cfg for the main > lcd and a .cfg for the remote.... neither should be selected. If they're working so well, the user can save the settings to make up a new theme. We could even have a "Save as..." dialog when selecting the modified theme. I disagree that neither should be selected. And we pretty much define a theme as 1 .cfg file. Received on 2009-06-29 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |