Rockbox mail archiveSubject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Mon, 29 Jun 2009 14:19:28 -0700
2009/6/29 Al Le <al.le_at_gmx.de>:
> On 29.06.2009 19:03, Jonathan Gordon wrote:
>> You exploit the fact that, technically speaking, a theme ist just a
>> .cfg file. But it's more. We have some settings that are called
>> "theme settings"
>> That is exactly my point... there is nothing special about theme .cfg
>> files.... Other than them being in the themes directory. They shouldnt be
>> treated any differently to regular file browsers.
> But, for some reasons, we do have the "Save Theme Settings" menu entry. As a
> result, a .cfg file is written, but that file will contain only some
> settings, not all. Hence some settings are considered to be part of the
> "theme" while others are not. Of course one can manually create a .cfg file
> with arbitrary settings and put it into the Themes directory. It will then
> be handled as a theme. But it's not the "official way" of doing it.
> So a theme is a .cfg file (located in a special directory) with a fixed set
> of settings in it. Anything else is a more general case of a "config."
That actually solves a problem though, The problem being that creating
themes was a PITA before.... what this thread/patch proposes doesnt
add anything and just creates more wierdness and potential problems
Received on 2009-06-29