Rockbox mail archiveSubject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
From: Al Le <al.le_at_gmx.de>
Date: Mon, 29 Jun 2009 23:34:57 +0200
On 29.06.2009 23:19, Jonathan Gordon wrote:
>> So a theme is a .cfg file (located in a special directory) with a fixed set
>> of settings in it. Anything else is a more general case of a "config."
> That actually solves a problem though, The problem being that creating
> themes was a PITA before.... what this thread/patch proposes doesnt
> add anything and just creates more wierdness and potential problems
The problem being solved by this patch is IMO that the user gets what he
would expect, i.e. the principle of least astonishment.
If I've loaded a theme and have not changed any theme related settings
I'd then expect that this theme would be pre-selected when I call
"Browse Themes." If at least one theme related setting has been modified
then we can add an asterisk or do something else (some ways have been
already proposed in this thread).
Received on 2009-06-29