Rockbox mail archiveSubject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
From: Paul Louden <paulthenerd_at_gmail.com>
Date: Mon, 29 Jun 2009 17:06:39 -0500
Al Le wrote:
> But then we also don't need to pre-select the font, for example. The
> reasoning is the same.
We don't need to, true. But pre-selecting the font doesn't come with a
downside the way pre-selecting a theme does, nor does it involve extra
complication to figure out what we actually need to show.
So, while we don't need to, there's not actually an argument not to in
this case. We can pretend like "Font" is merely a setting safely because
it does actually work in a way indistinguishable from single-value
settings. We can't pretend like "themes" work the same as single-value
settings ever, because they change other things. Nor can we even
simulate treating them like single-value things without special case
code to determine if those other settings have changed, and fallback
cases for what to do if they have.
Received on 2009-06-30