Rockbox mail archiveSubject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Mon, 29 Jun 2009 16:02:14 -0700
2009/6/29 Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>:
> Jonathan Gordon wrote:
>> At this point I'm going to bow out of the discussion with this comment....
>> *If* the patch does nothing but preselect the last selected config
>> then I wouldn't exactly be happy, but I'd let it slide... any extra
>> complication trying to do dirty checking, or reverting or other
>> weirdness I'd strongly object to on the grounds that the codebase is
>> difficult enough as it is without making it worse with obscure
>> features which are not necessary.
> You just guess on the complexity, don't you? Where do you exactly see
> enbearable code complication?
> BTW, I don't think we need to check against the non-dirty value. Simply mark
> it dirty once, and keep it until a new theme is loaded.
take this any way you want... but I don't think anyone can say they
know the settings handling code more than me, so yes I'm guessing, but
its a pretty educated guess.
Received on 2009-06-30