Rockbox mail archiveSubject: FS#10440 (toggle the pitch changing mode in the other direction): tests and a commit permission needed
FS#10440 (toggle the pitch changing mode in the other direction): tests and a commit permission needed
From: Al Le <al.le_at_gmx.de>
Date: Mon, 20 Jul 2009 22:19:21 +0200
As of now, the pitch changing mode (which on SW_CODEC platforms can have
up to four "values") can only be changed cyclically in one direction.
That leads to the following problem:
Assume you're separately changing the speed and the pitch (i.e. you use
the timestretch feature). After having changed the pitch in semitone
steps, you'd like to do fine tuning in procentual mode (ok, for me
personally it's rather theretical since semitone steps are quite small
thus allowing fine tuning, but still...). But to reach the desired mode
you'd have to go through the "Rate" mode. Thus the speed and the pitch
would be set to the same value in between.
To avoid that, I've created the patch FS#10440 that allows to cycle
through pitch changing modes in the opposite direction.
Would you support such patch? I tested it on H120 and Sansa e200, it
seems to work well. I also changed the key mapping for other players but
have not tested them all.
Now I need two things. First, you support and approvement in committing
this patch (i.e. whether the feature is welcome). And second, some tests
on other platforms.
PS. Should I also post this to the user mailing list?
Received on 2009-07-20