Rockbox mail archiveSubject: Re: teru r22143: trunk/apps/plugins
Re: teru r22143: trunk/apps/plugins
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 04 Aug 2009 11:31:01 +0200
Teruaki Kawashima schrieb:
> a) try to find the highlevel from the high scores is not correct. it's
> my mistake to remove that code though, there is no need to do so...
Didn't bubbles always do that though?
> c) removing file causes disk access even though the file doesn't exist.
> I agree that my change is not so good and better solution is needed.
> same thing would be applied to other plugins like brickmania and jewels.
I think my solution wasn't bad afterall. Bubbles always accessed the
disk at resuming, so that's not really an argument. But, you removed a
(imo) very useful feature, to play bubbles without messing up the saved
> d) to match behavior with other plugins which use highscore.
We don't need two quit items then, if both cause disk access, IMO.
You changed bubbles way more than you described in your commit message.
Try to be more verbose please.
Received on 2009-08-04