Rockbox mail archiveSubject: Re: Weird code in r22153 (changes to strnatcmp.c)
Re: Weird code in r22153 (changes to strnatcmp.c)
From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Wed, 12 Aug 2009 10:42:38 +0200
On Wed, Aug 12, 2009 at 10:36:09AM +0200, Al Le wrote:
> On 12.08.2009 01:13, Thomas Martitz wrote:
> I would also remove the code that is now deactivated via "#if 0." Such
> things always make me ask whether the author wanted to just temporarily
> deactivate the code or ...? The similarity to the original code must not
> necesserily be maintained in this particular case IMO. We should make
> code easily readable and understandable instead.
I agree. We're not going to merge back from wherever this code came
from, since we seem to have pretty different requirements, and it's
pretty simple code anyway. Best clean it up.
-- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. KernighanReceived on 2009-08-12