|
Rockbox mail archiveSubject: Re: A question about r22222 (Factoring out the parsing of %V tag)Re: A question about r22222 (Factoring out the parsing of %V tag)
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Wed, 12 Aug 2009 13:35:05 +0200 Al Le schrieb: > Hello. > > I saw the changes made in r22222 (nice number by the way! :-) And I > ask myself why this change had to be made. IMO the parser code should > be separated from the "pure API and data structures" code (since > parsing might happen in another way for example, without any changes > in the viewport API itself). But this change brings them together. > What was the reason. > > This question is for kugel (the developer who made the change) in the > first line but for others who can explain the reason as well. > > Thanks! The commit message says it ("in preparation of customlist"). FS#8799 will need it to parse a viewport from the settings. To make the final diff smaller I committed this beforehand. Now please question someone else's code :D Best regards. Received on 2009-08-12 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |