From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Fri, 14 Aug 2009 11:32:10 +0200

On Fri, Aug 14, 2009 at 11:27:26AM +0200, Al Le wrote:
> On 14.08.2009 08:44, Jonathan Gordon wrote:
>
>> The patch isnt 100% complete, but I dont want to keep working outside
>> of svn on it because the previous attempt died when the patch got too
>> huge and a small change somewhere broke everything...
>>
>> So, does anyone have any objections to me commiting it as it is (after
>> the needed error handling code is added)?
>
> I'd say it depends. If the patch in its current state makes the player
> unusable then I'm against committing the patch. But if it would still be
> usable and just some leftovers would need to be fixed then go for it.

I think it's highly unlikely that someone would propose a commit that
makes rockbox unusable.

Frank

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

Received on 2009-08-14