From: Jeff Goode <jeffg7_at_gmail.com>
Date: Sun, 13 Sep 2009 09:18:32 -0400

Jonas Häggqvist wrote:
> mailer_at_svn.rockbox.org wrote:
>
>> Date: 2009-09-13 06:16:25 +0200 (Sun, 13 Sep 2009)
>> New Revision: 22690
>>
>> Log Message:
>> Laying the groundwork for future features
>>
>> Modified:
>> trunk/apps/lang/english.lang
>> trunk/apps/lang/francais.lang
>> trunk/apps/lang/italiano.lang
>> trunk/apps/lang/polski.lang
>> trunk/apps/lang/svenska.lang
>> trunk/apps/lang/tagalog.lang
>> trunk/apps/settings_list.c
>>
>> Modified: trunk/apps/lang/english.lang
>> ===================================================================
>> --- trunk/apps/lang/english.lang 2009-09-12 22:31:29 UTC (rev 22689)
>> +++ trunk/apps/lang/english.lang 2009-09-13 04:16:25 UTC (rev 22690)
>> _at__at_ -12702,7 +12702,7 _at__at_
>> </voice>
>> </phrase>
>> <phrase>
>> - id: LANG_LIMITER
>> + id: LANG_COMPRESSOR
>> desc: in sound settings
>> user: core
>> <source>
>>
>
> I don't believe modifying language files like this is good. The correct
> way is to first deprecate LANG_LIMITER, then add LANG_COMPRESSOR at the
> end of the file. This way old language files and voice files will still work.
>
> Or am I just confused?
>
>
I thought it might be a problem at first, so I tested it. I changed the
label everywhere it occurred within the source code, including those
lang files where a translation was offered. I'm not making it go away
or relocating it, only changing its name globally, and so far it appears
there are no ill effects. I wanted to change the label before more
translations were worked on, you see. I plan to change the limiter to a
full blown dynamic range compressor, so the label makes more sense this way.

Jeff
Received on 2009-09-13