Rockbox mail archiveSubject: Re: the UI viewport logic.. someone please help my understanding?
Re: the UI viewport logic.. someone please help my understanding?
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Wed, 28 Oct 2009 21:01:32 +0100
Jonathan Gordon schrieb:
> no it doesnt... screens would still call _get_defaults or _fullscreen,
> but the code behind them will be simpler. (And im now annoyed I'm at
> work and cant look at the code to prove my point... but anyway I didnt
> want to talk code in this discussion)
It's *very* simple behind the scenes at the moment, IMO.
>> That consistency in the code isn't existent. Neither viewport_set_defaults()
>> nor _fullscreen() check in which screen one currently is. There's no
>> thinking or checking. There's no such check at all in any of the related
>> areas. It just depends on what of the both functions you call, which existed
>> before sbs.
>> The former gets you the current UI viewport (no matter whether there's an
>> sbs or not), the latter gets you the the maximized viewport minus statusbar
>> area (no matter whether there's an sbs or not).
> ok, time to take a step back... how can _fullscreen() not be returning
> the real full screen?! that really makes no sense... now, if it was
> named get_fullscreen_minus_sbs_area() or simply _get_defaults() I
> could understand... but fullscreen implies it gets the whole
No idea, you wrote the function to act like that. You even defended the
way it excludes the statusbar area back when I proposed a "ignore
statusbars"/"really, fullscreen" parameter. Anyway, renaming is a simple
Received on 2009-10-28